Page 1 of 1

What is the expected behavior of inline editing?

Posted: Thu May 22, 2014 9:34 am
by sledgehammer_999
Hey guys, I want some of your input.
I am going to implement inline editing. If you don't know what it is look at the attached screenshot.
My question/problem is this. As you may know depending on the active "filter" the torrents appear or dissappear from the view depending on their progress over time. So what is the expected behavior in the following scenario:
1. "Downloading" filter is selected
2. You start inline editing/renaming a downloading torrent
3. The torrent finishes the downloading while you are still editing it.

What is the expected behavior in this situation? Should the torrent disappear from the current view and the editing aborted or should the torrent stay in the view until the editing is finished(or aborted by the user) regardless of the torrent's status?

Image

Re: What is the expected behavior of inline editing?

Posted: Thu May 22, 2014 11:50 am
by gwarser
Should stay in the view until the editing is finished, and then disappear

Re: What is the expected behavior of inline editing?

Posted: Fri May 30, 2014 4:16 pm
by Muzak
Stay in view until edit is done would be preferred behavior. If not possible then cancel the edit (ie revert to original description) to avoid a really confusing partial name to be assigned.

Re: What is the expected behavior of inline editing?

Posted: Fri May 30, 2014 7:52 pm
by ciaobaby
Or just lock the GUI update cycle while editing.

Re: What is the expected behavior of inline editing?

Posted: Sun Jun 01, 2014 11:53 am
by gwarser
Definitely should be locked (current line at least), to prevent jumping up and down in queue.

Re: What is the expected behavior of inline editing?

Posted: Sun Jun 01, 2014 5:24 pm
by ciaobaby
And of course sorting by a non-volatile column (and category) before  renaming could help.

Re: What is the expected behavior of inline editing?

Posted: Sun Jun 01, 2014 7:52 pm
by sledgehammer_999
The tricky part is to keep the other items refreshing without refreshing the still-editing item. To be more precise to keep the still-editing item refreshing but not have it disappear from the view. eg if you have the "downloading" enabled and the torrent finishes downloading while you still are editing it.
The way the code is structured it is difficult to find a suitable point to plant a "edit" flag, so the code will not touch that item.
I'll solved it when I find time. The above was just a proof of concept.